Skip to content

Don't fail on ID token expiration #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't fail on ID token expiration #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/Token/AccessToken.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace TheNetworg\OAuth2\Client\Token;

use Firebase\JWT\ExpiredException;
use Firebase\JWT\JWT;
use InvalidArgumentException;
use League\OAuth2\Client\Tool\RequestFactory;
Expand Down Expand Up @@ -37,13 +38,16 @@ public function __construct(array $options, $provider)
// Then parse the idToken claims only without validating the signature
$idTokenClaims = (array)JWT::jsonDecode(JWT::urlsafeB64Decode($tks[1]));
}
} catch (JWT_Exception $e) {

$provider->validateTokenClaims($idTokenClaims);
$this->idTokenClaims = $idTokenClaims;

} catch (ExpiredException $e) {
// ID token expired, but whatever ...

} catch (UnexpectedValueException $e) {
throw new RuntimeException('Unable to parse the id_token!');
}

$provider->validateTokenClaims($idTokenClaims);

$this->idTokenClaims = $idTokenClaims;
}
}

Expand Down