[GEN][ZH] Unify code of GameAudio and MilesAudioManager

[Mauller]

Squash and merge

This PR makes the changes required to synchronize the audio implementations between Generals and Zero hour.

Most changes are backports to Generals, while some small tweaks are made to zero hour to match generals.

• Merge After: [GEN][ZH] Remove all instances of stopAllAmbientsBy() #793

[Mauller]

Updated and addressed the discussed points above, will push a small followup PR to remove the stragling bits of code associated with the removed interface functions from GameAudio.

[Mauller]

Had to make a small push again to include the removal of calls to stopAllAmbientSoundsBy() since the build pipeline would fail otherwise for the generals build.

There are so few instances where these functions are called that it might as well be a part of this PR.

[xezon]

Is this change meant to be merged with rebase or not?

Commit number 3 of this change appears to error:

Error: D:\a\GeneralsGameCode\GeneralsGameCode\Generals\Code\GameEngine\Source\GameLogic\Object\Die\FXListDie.cpp(69) : error C2039: 'stopAllAmbientsBy' : is not a member of 'AudioManager'

[Mauller]

Is this change meant to be merged with rebase or not?

Commit number 3 of this change appears to error:

Error: D:\a\GeneralsGameCode\GeneralsGameCode\Generals\Code\GameEngine\Source\GameLogic\Object\Die\FXListDie.cpp(69) : error C2039: 'stopAllAmbientsBy' : is not a member of 'AudioManager'

The build of this PR should be fixed with the last commit i made to add removing those calls to stopAllAmbientsBy

since MilesAudioManager inherits from GameAudio, those two commits are kind of interdependent, so i thought it would be better to squash and merge this.

But merging by rebase should be okay, i tweaked the PR description above to cover this.

[xezon]

If commit number 3 fails to compile on its own, then it cannot be merged with rebase.

[Mauller]

If commit number 3 fails to compile on its own, then it cannot be merged with rebase.

Reordered the commits to break the problematic dependency.

[sorcerer86pt]

LGTM

[xezon]

There are now 3 commits that remove pieces of stopAllAmbientsBy in different places. How about put the removal for stopAllAmbientsBy in one commit? I suggest create one new pull request where this stopAllAmbientsBy stuff is removed first, then we see next steps.

[Mauller]

Seperated that out and into #793

[Mauller]

This will may at the moment till #793 is merged before it.

[xezon]

Can we merge this with Squash?

[Mauller]

Can we merge this with Squash?

Yeah should be fine, can encapsulate the changes in one.

[xezon]

Ok. Adjusted the title of this change.

[Mauller]

Rebased with main so good to go.