Skip to content

Make local distributor broadcast Publish call blocking #4680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Sep 29, 2021

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/573

Changes

  • Add options to io.Subscription which allows the creator to control if the Publish call blocks or not
  • Make the local distributor subscription set generate subscriptions for whom Publish blocks
    • This very specific subscription set contains the subscriptions for the webhooks and application packages frontends
    • These frontends already have their own buffering (via pkg/workerpool) and can decide on their own if they should drop traffic or not. We can also see when traffic was lost here via metrics.
    • This ensures that we don't lose traffic into the nether when we have bursts or high traffic amounts

Testing

Unit testing covers this.

Regressions

N/A

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.15.1 milestone Sep 29, 2021
@adriansmares adriansmares self-assigned this Sep 29, 2021
@github-actions github-actions bot added the c/application server This is related to the Application Server label Sep 29, 2021
@adriansmares adriansmares force-pushed the feature/block-on-local-distributor branch from 18bcdac to 3ca1d7e Compare September 29, 2021 16:18
@adriansmares adriansmares marked this pull request as ready for review September 29, 2021 16:34
@adriansmares adriansmares merged commit 228c615 into v3.15 Sep 30, 2021
@adriansmares adriansmares deleted the feature/block-on-local-distributor branch September 30, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants