-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Is this project still alive? #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I still use it religiously. |
I have tried to use it lately but i have a warning ... using php 7.4.30. |
That is just a notice - but it works despite that??...... I use it with 8.0, no issues... But, I agree, would like some input from the author, @ThingEngineer |
Yeah it does work, is just annoying :) |
Sorry guys, I'll work this notice next week.
Apart from that everything is working fine in the library?
I'll release next version with this fix.
…On Sun, Sep 11, 2022, 2:34 PM mihaiflorio ***@***.***> wrote:
I still use it religiously.
I have tried to use it lately but i have a warning ... using php 7.4.30.
PHP Notice: Undefined offset: 0 in
vendor/thingengineer/mysqli-database-class/MysqliDb.php on line 559
—
Reply to this email directly, view it on GitHub
<#995 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZCL4XADZVMYQKNAA7SYQDV5YQ5BANCNFSM572YMTFA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
@avbdr on php 7.4.30 seems to work just fine (apart of the notice). Thanks a lot for fixing it. |
Hi guys, I'm using this package since 2016 and it worked always very well. Just let me know, in case. Bye! |
@funder7 it does work, i use it with php8. there is indeed that weird notice (but it does not break the code). |
I dont know what else to add to the library, I think it is good as is and further "improvements" less likely will bring anything major anymore. |
@avbdr totally agree, there is no need for further improvements, just the fix for php8. I do not think is too much work, I can pay you to fix it (my OCD always is getting crazy when I see the NOTICE from the library) :)))))) |
You should only have notices on for debugging....... So you'd pay for something to be fixed when you have the option to turn off........ Hell, I'd fix it for £100......... |
Sure, I was referring to fixing any warning to make it fully compatible with php 8.x, no need to add other functionalities IMHO. |
…d issues (#995, #967, #928) This commit fixes the "Undefined offset: 0" error that occurred in the rawAddPrefix function when using backtick delimiters for table names in SQL queries. It also addresses issues reported in tickets #995, #967, and #928, which were likely related to the same underlying problem with table name identification. Changes: Updated the regular expression in rawAddPrefix to match backtick characters (\) as valid delimiters for table names. This fix ensures that the function correctly identifies and prefixes table names regardless of the delimiter used.
I don't see too much movement in the last 2 years...
The text was updated successfully, but these errors were encountered: