Fixes a PHP 8.4 Compatibility Issue #1045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MysqliDb::insertMulti(): Implicitly marking parameter $dataKeys as nullable is deprecated, the explicit nullable type must be used instead in MysqliDb.php on line 850.
|
Thank you for the patch. I assume that would break php4? (Not sure if
somebody still needs php4...)
…On Tue, Feb 18, 2025, 11:09 AM Sebastian Boo ***@***.***> wrote:
MysqliDb::insertMulti(): Implicitly marking parameter $dataKeys as
nullable is deprecated, the explicit nullable type must be used instead in
MysqliDb.php on line 850.
Fixes #1044
<#1044>
------------------------------
You can view, comment on, or merge this pull request online at:
#1045
Commit Summary
- c14716f
<c14716f>
Fixes a PHP 8.4 Compatibility Issue
File Changes
(1 file
<https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045/files>
)
- *M* MysqliDb.php
<https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045/files#diff-ffa8f8b94ca4a1d6e37401846c71a534315221a6834cd36788a99058742d4699>
(2)
Patch Links:
-
https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045.patch
-
https://github.com/ThingEngineer/PHP-MySQLi-Database-Class/pull/1045.diff
—
Reply to this email directly, view it on GitHub
<#1045>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZCL4SBO57MG2HMDPWDXET2QNEJZAVCNFSM6AAAAABXL4GZDGVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA3DANZTGYZTGMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
This will probably break everything below 7.1, thats when the nullable types was introduced |
|
If there are concerns about backwards compatibility would it not be wise to branch the project ? start v3 for say > 8.0 (or 7.4 or whatever) and keep a v2.9.x maintenance branch for whatever current minimum is up to 8.3 ?? https://www.php.net/supported-versions Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MysqliDb::insertMulti(): Implicitly marking parameter $dataKeys as nullable is deprecated, the explicit nullable type must be used instead in MysqliDb.php on line 850.
Fixes #1044