Skip to content

Adding support for mysql error codes #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2016
Merged

Conversation

Ettemlevest
Copy link
Contributor

@avbdr
Copy link
Collaborator

avbdr commented Apr 22, 2016

can you please update readme as well? thank you

@Ettemlevest
Copy link
Contributor Author

Thanks for the reminder. I added a small description to the readme.

@avbdr
Copy link
Collaborator

avbdr commented Apr 22, 2016

as well, I noticed you are not cleaning up errno variable in reset() function. Its getting called after each query execution to remove all the data

@Ettemlevest
Copy link
Contributor Author

I just added the errno parts after every $_stmtError lines but I did not check to reset the values. In this case we should also reset the $_stmtError string.

@avbdr
Copy link
Collaborator

avbdr commented Apr 22, 2016

sorry, my bad, this variables shouldnt be reset :) as you are using them after execution
fine. ill land this as is

@avbdr avbdr merged commit a62e491 into ThingEngineer:master Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants