Build for Scala 2.13.0

[Atry]

• Scala
• Scala.js
• Scalaz
• ScalaTest - Publish for Scala 2.13.0 (yes, it's now released!) scalatest/scalatest#1601
• sde - Upgrade to Scala 2.13.0 sde#11
• Extractor.scala - Upgrade to Scala 2.13.0 Extractor.scala#19
• Q.scala - Build for Scala 2.13.0 Q.scala#3
• ScalaTags - https://repo1.maven.org/maven2/com/lihaoyi/scalatags_2.13/
• Reimplement SafeBuffer for Scala 2.13 collections
• Reimplement Proxy for Scala 2.13 collections

[Atry]

An working in process branch for Scala 2.13:
https://github.com/Atry/Binding.scala/tree/scala-2.13-wip

[adrobisch]

Hi, would be nice to see a 2.13 release. Is there a way / need to help out on this one?

[Atry]

You can try to checkout https://github.com/Atry/Binding.scala/tree/scala-2.13-wip and fix compilation errors. You may need to add some @enableMembersIf annotation for Scala 2.13 only code.

[adrobisch]

I did a sbt test on that branch after adding some openjfx dependencies and only one error appeared:

fxml/.jvm/src/test/scala/com/thoughtworks/binding/FxmlSample.scala:19:8: ambiguous implicit values:
[error]  both method javaBeanTyper in trait LowPriorityBuilder of type [A](implicit constructor: com.thoughtworks.binding.fxml.Runtime.EmptyConstructor[A])com.thoughtworks.binding.fxml.Runtime.JavaBeanPropertyTyper[A]
[error]  and macro method javafxTyper in object PropertyTyper of type [A]=> com.thoughtworks.binding.fxml.Runtime.PropertyTyper[A]
[error]  match expected type com.thoughtworks.binding.fxml.Runtime.PropertyTyper[javafx.stage.Stage]
[error]       <Stage title={text}>
[error]   

All other tests are green. Am I missing something or is that what you meant?

[Atry]

There should be more compilation errors. See https://travis-ci.org/Atry/Binding.scala/builds/548268187

[adrobisch]

Sorry did not run a cross build, will take a look.

[adrobisch]

Invested a bit of time here: master...adrobisch:scala-2.13-wip
I fixed all the library versions to my best knowledge and migrated SafeBuffer to 2.13. In Binding.scala however the collection changes are a bit more complicated. I worked on migrating Proxy which should work out but is WIP. HasCache however is having issues with Scala.js interfaces which are still like 2.12 as far as I understand the compiler errors, which looks like it needs bigger changes.

[Atry]

I think we should implement Proxy as a SeqView instead of a Seq in Scala 2.13, also the type of BindingSeq.value should be SeqOps instead of a Seq.

[adrobisch]

Its pretty hard for me to work on the codebase with all the versioning and target (mostly Scala.js) implications. I also dont feel comfortable doing the proposed changes given my current level of understanding, so I will not follow-up on this at the moment. Feel free to pick whatever you like from my branch.

[Atry]

I know it's really hard to keep the ability of cross compilation when there are plenty of API changes in standard library. Thanks for your attempting implementation!

[Atry]

Since the collection API changes in Scala 2.13, it is impossible to support Scala 2.13 without breaking backward-compatibility.

Therefore, the work for Scala 2.13 are implemented in the next major version, Binding.scala v12. There is an unstable version here: https://github.com/ThoughtWorksInc/Binding.scala/releases/tag/v12.0.0-M0

The templating libraries, dom and fxml are dropped, in favor of html.scala (and your own XML templating libraries based on Name Based XML Literals).