Skip to content

avoid customMessage in case class logs #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2017
Merged

avoid customMessage in case class logs #44

merged 3 commits into from
Apr 28, 2017

Conversation

izhangzhihao
Copy link
Contributor

see #35

@izhangzhihao izhangzhihao added this to the sprint-2017-04-28 milestone Apr 28, 2017
Atry
Atry requested changes Apr 28, 2017
View reviewed changes
Copy link
Collaborator

@Atry Atry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need more expressive naming and message

@izhangzhihao izhangzhihao merged commit da91b44 into ThoughtWorksInc:2.0.x-v20 Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atry Atry Atry requested changes

Assignees

@izhangzhihao izhangzhihao

Labels
None yet
Projects
None yet
Milestone
sprint-2017-04-28
Development

Successfully merging this pull request may close these issues.
2 participants
@izhangzhihao @Atry