Correct full_domain=True
For from_pandas
#1239
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tile_max
was only correctly calculated fornp.int64
. This correctly set thedim_max
todtype_max - tile
but only for
np.int64
dim_max
set todtype_max
whichresulted in a domain range that was too large
the range of the full domain. For an instance, when we have a dim
dtype of
np.int8
, the default tile extent of 10000 will be muchlarger than the range of the full domain