handle Timer without Clock #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Timer
without setting up aClock
raises an IndexError:Output:
The exception happens at
ttboard/cocotb/triggers/timer.py
line 22:tt-micropython-firmware/src/ttboard/cocotb/triggers/timer.py
Line 22 in bb061d2
This PR is a quick and dirty fix for this specific case when
all_clocks
is empty. There are some other edge cases where eitherself.time
or some of the other clocks aren't a multiple of the fastest clock, but we can deal with them later.