Skip to content

Issue #922 :Removing some hints in helps-thread #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 12, 2023
Merged

Issue #922 :Removing some hints in helps-thread #934

merged 9 commits into from
Nov 12, 2023

Conversation

AdityaM2205
Copy link
Contributor

@AdityaM2205 AdityaM2205 commented Oct 25, 2023 •
edited by Taz03
Loading

The two obselete hints have been removed entirely from the list
image

@AdityaM2205
Issue Together-Java#922 :Removing some hints in helps-thread
41f1a1b 
The two obselete hints have been removed entirely from the list
@AdityaM2205 AdityaM2205 requested review from a team as code owners October 25, 2023 07:42
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Zabuzard Zabuzard linked an issue Oct 25, 2023 that may be closed by this pull request
Remove some hints in help-threads #922
Closed
@Zabuzard Zabuzard added enhancement New feature or request priority: normal labels Oct 25, 2023
Zabuzard
Zabuzard previously approved these changes Oct 25, 2023
View reviewed changes
Taz03
Taz03 previously approved these changes Oct 25, 2023
View reviewed changes
@Taz03 Taz03 dismissed their stale review October 25, 2023 08:42

failed ci

@ankitsmt211
Copy link
Member

@AdityaM2205 Are you still upto this? couple of checks failed.

@AdityaM2205
Copy link
Contributor Author

I'm sorry,I tried modifying the dependencies a little,but the tests still don't pass,kindly assign the issue to someone else

@Taz03 Taz03 self-assigned this Nov 7, 2023
@ankitsmt211
Copy link
Member

I'm sorry,I tried modifying the dependencies a little,but the tests still don't pass,kindly assign the issue to someone else

No worries, thank you for trying you were almost there. Btw if you get stuck or plan to contribute further feel free to ask questions here or in our server. We'd be happy to help.

Taz03
Taz03 previously approved these changes Nov 7, 2023
View reviewed changes
@Taz03 Taz03 requested review from Zabuzard and ankitsmt211 November 7, 2023 18:26
@ankitsmt211
Copy link
Member

@Taz03 Please add the screenshot for new prompts.

Taz03
Taz03 previously approved these changes Nov 8, 2023
View reviewed changes
@Taz03 Taz03 dismissed their stale review November 8, 2023 18:02

needs changes

@Taz03
Copy link
Member

Taz03 commented Nov 8, 2023

sonarlint is complaining because embedWith have no usage now, should I remove it or should keep it?

@ankitsmt211
Copy link
Member

sonarlint is complaining because embedWith have no usage now, should I remove it or should keep it?

i don't see a reason to keep it, the only place it was used is no longer using it.

@Taz03 Taz03 requested a review from ankitsmt211 November 11, 2023 18:32
ankitsmt211
ankitsmt211 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@ankitsmt211 ankitsmt211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good.

@Taz03 Taz03 merged commit a659d32 into Together-Java:develop Nov 12, 2023
@Zabuzard Zabuzard mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitsmt211 ankitsmt211 ankitsmt211 approved these changes

@Taz03 Taz03 Taz03 approved these changes

@Zabuzard Zabuzard Awaiting requested review from Zabuzard

Assignees

@Taz03 Taz03

@AdityaM2205 AdityaM2205

Labels
enhancement New feature or request priority: normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove some hints in help-threads
5 participants
@AdityaM2205 @CLAassistant @ankitsmt211 @Taz03 @Zabuzard