Skip to content

Bug/ allows OP of embed from transfer to dismiss GPT's response #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 16, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -157,19 +157,15 @@ public void acceptComponentIdGenerator(ComponentIdGenerator generator) {
@Override
public void onButtonClick(ButtonInteractionEvent event, List<String> args) {
// This method handles chatgpt's automatic response "dismiss" button
event.deferEdit().queue();

ThreadChannel channel = event.getChannel().asThreadChannel();
Member interactionUser = Objects.requireNonNull(event.getMember());
if (channel.getOwnerIdLong() != interactionUser.getIdLong()
&& !helper.hasTagManageRole(interactionUser)) {
event.reply("You do not have permission for this action.").setEphemeral(true).queue();
return;
}

RestAction<Void> deleteMessages = event.getMessage().delete();
for (String id : args) {
deleteMessages = deleteMessages.and(channel.deleteMessageById(id));
}
deleteMessages.queue();
channel.retrieveMessageById(channel.getId())
.queue(forumPostMessage -> handleDismiss(interactionUser, channel, forumPostMessage,
event, args));

}

@Override
Expand All @@ -182,4 +178,40 @@ public void onModalSubmitted(ModalInteractionEvent event, List<String> args) {
throw new UnsupportedOperationException("Not used");
}

private boolean isPostAuthor(Member interactionUser, Message message) {
if (message.getEmbeds().isEmpty())
return false;

String embedAuthor = Objects
.requireNonNull(message.getEmbeds().get(0).getAuthor(),
"embed author for forum post is null")
.getName();

return embedAuthor.equals(interactionUser.getUser().getName());
}

private boolean isAuthorized(Member interactionUser, ThreadChannel channel,
Message forumPostMessage) {
return (channel.getOwnerIdLong() == interactionUser.getIdLong())
|| helper.hasTagManageRole(interactionUser)
|| isPostAuthor(interactionUser, forumPostMessage);
}

private void handleDismiss(Member interactionUser, ThreadChannel channel,
Message forumPostMessage, ButtonInteractionEvent event, List<String> args) {
boolean isAuthorized = isAuthorized(interactionUser, channel, forumPostMessage);
if (!isAuthorized) {
event.getHook()
.sendMessage("You do not have permission for this action.")
.setEphemeral(true)
.queue();
return;
}

RestAction<Void> deleteMessages = event.getMessage().delete();
for (String id : args) {
deleteMessages = deleteMessages.and(channel.deleteMessageById(id));
}
deleteMessages.queue();
}
}