Skip to content

feat: 添加了首页文章列表置顶功能 #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: 添加了首页文章列表置顶功能 #103

wants to merge 1 commit into from

Conversation

moxiaonai
Copy link
Contributor

@moxiaonai moxiaonai commented Feb 26, 2023 •
edited
Loading

如题：添加了首页文章列表置顶功能，效果如下图

image

@Tokinx
Copy link
Owner

Tokinx commented Feb 27, 2023

非常感谢这个PR，但是代码执行效率似乎有待提升与优化。
我认为应该从order入手将sticky的文章排到最上面，而不是分两次查询将结果合并。

再次感谢你的支持与贡献，此PR可能暂时不会合并到主分支。

@moxiaonai
Copy link
Contributor Author

moxiaonai commented Feb 28, 2023 •
edited
Loading

非常感谢这个PR，但是代码执行效率似乎有待提升与优化。 我认为应该从order入手将sticky的文章排到最上面，而不是分两次查询将结果合并。

再次感谢你的支持与贡献，此PR可能暂时不会合并到主分支。

@Tokinx
是的，按排序处理一次查询应该是最优解，wp默认排序置顶应该会返回在最上面，但是因为现在的代码已经有了orderby=>date，我试着调整了现在的自定义查询条件，试了一下没有实现，最后没敢大改怕影响到其他统计，
上面的方案是参考了dux的做法，他的方案是为了满足自定义置顶id，放在这里确实不是最合适的，期待大佬有更优雅的方式

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moxiaonai @Tokinx