Added "Video Capture Device" as a capture method #143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty-masks Fix #52 Comparisons with empty masks
…hread Show errors outside main thread
…-errors-outside-main-thread
…hread Fixes Toufool#86 Stop uncaught exceptions from silently crashing the app
…on't allow a start image to load if hotkeys are not set.
Configured VSCode and Markdownlint settings Added and configured the following linters as strict as I could: pylint, flake8, mypy, bandit, pyright Partially filled in some type stubs: cv2, imagehash, keyboard, pyautogui, pythonwin, win32helper [Breaking change] Using interpolation=cv2.INTER_NEAREST everywhere as it is the fastest interlpolation method Hide generated/compiled files SelectRegionWidget width and height as functions Added validate_images_before_parsing() to validate images both before maxFPS and starting autosplitter
First linting pass
…-'Check-For-Updates-On-Open'-immediatly
…-Open'-immediatly Async check for updates + Save 'check for updates on open' immediately
Configured Building and linting workflow
Pylint + Flake8 linting
Merge dev to 2.0.0
Avasam
force-pushed
the
camera-capture-split-cam-option
branch
from
7a2ad2c to
3ca7dbe
Compare
Fixes #21 Updated some doc max fps will show `...` while working
Avasam
force-pushed
the
camera-capture-split-cam-option
branch
from
b84f075 to
0ad99bf
Compare
Avasam
force-pushed
the
camera-capture-split-cam-option
branch
from
0e8583f to
0af8ce3
Compare
Avasam
force-pushed
the
camera-capture-split-cam-option
branch
4 times, most recently
from
5fa5572 to
de40b92
Compare
- Use win32gui.IsWindow for hwnd checks - is_valid_image TypeGuard
Avasam
force-pushed
the
camera-capture-split-cam-option
branch
from
de40b92 to
33c46d4
Compare
Avasam
force-pushed
the
camera-capture-split-cam-option
branch
2 times, most recently
from
7f6eff9 to
0269cb4
Compare
Avasam
force-pushed
the
camera-capture-split-cam-option
branch
from
0269cb4 to
6dbb6da
Compare
|
Closing in favor of #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #141
Relates to #134
This adds "Video Capture Device" as a capture method. A different dropdown is used to select the capture device. I've tried putting them all in the same dropdown (https://github.com/Avasam/Auto-Split/pull/18/files), but this way is so much cleaner.
There's a huge limitation with Capture Devices in CV2: You can't list existing devices. This means to get all devices, we need to try all of them individually by index, which is slow as the camera also needs to initialize then close. I'm currently maxing out this process at 8 devices. We also currently have no way of obtaining a device's name.
I'm also setting this as draft, because while DroidCam, my Logitech cam and my StartTech capture card all worked, (they seem to use the MSMF backend). There's one DSHOW backend cam that didn't (black screen, video glitches, slows down the app to a crawl). And I'm assuming that would be the OBS virtual camera. Which is the whole reason behind this feature.(see comment below)Result:
The framerate is decent too: