Skip to content
This repository was archived by the owner on Apr 3, 2025. It is now read-only.

Commit e2d7fc3

Browse files
author
Harald Walker
committed
messagebird#17 Fix constructor with serviceUrl and remove obsolete imports
1 parent cd7b52a commit e2d7fc3

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

api/src/main/java/com/messagebird/MessageBirdService.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
package com.messagebird;
22

3+
import java.util.Map;
4+
35
import com.messagebird.exceptions.GeneralException;
46
import com.messagebird.exceptions.NotFoundException;
57
import com.messagebird.exceptions.UnauthorizedException;
68

7-
import java.io.UnsupportedEncodingException;
8-
import java.util.Map;
9-
109
/**
1110
* Created by rvt on 1/7/15.
1211
*/

api/src/main/java/com/messagebird/MessageBirdServiceImpl.java

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,26 @@
11
package com.messagebird;
22

3-
import com.messagebird.exceptions.GeneralException;
4-
import com.messagebird.exceptions.NotFoundException;
5-
import com.messagebird.exceptions.UnauthorizedException;
6-
import com.messagebird.objects.ErrorReport;
3+
import java.io.IOException;
4+
import java.io.InputStream;
5+
import java.io.UnsupportedEncodingException;
6+
import java.net.HttpURLConnection;
7+
import java.net.Proxy;
8+
import java.net.URL;
9+
import java.net.URLEncoder;
10+
import java.util.Arrays;
11+
import java.util.LinkedHashMap;
12+
import java.util.List;
13+
import java.util.Map;
14+
715
import org.codehaus.jackson.JsonNode;
816
import org.codehaus.jackson.map.DeserializationConfig;
917
import org.codehaus.jackson.map.ObjectMapper;
1018
import org.codehaus.jackson.map.annotate.JsonSerialize;
1119

12-
import java.io.IOException;
13-
import java.io.InputStream;
14-
import java.io.OutputStream;
15-
import java.io.UnsupportedEncodingException;
16-
import java.net.*;
17-
import java.util.*;
20+
import com.messagebird.exceptions.GeneralException;
21+
import com.messagebird.exceptions.NotFoundException;
22+
import com.messagebird.exceptions.UnauthorizedException;
23+
import com.messagebird.objects.ErrorReport;
1824

1925
/**
2026
* Implementation of MessageBirdService
@@ -31,7 +37,7 @@ public class MessageBirdServiceImpl implements MessageBirdService {
3137
private static final String REQUEST_TYPE_MUST_BE_SET_TO_GET_OR_POST = "Request type must be set to GET, POST or DELETE";
3238
private static final List<String> REQUESTMETHODS = Arrays.asList(new String[]{"GET", "POST", "DELETE"});
3339
private final String accessKey;
34-
private final String serviceUrl = "https://rest.messagebird.com";
40+
private final String serviceUrl;
3541
private final String clientVersion = "1.2.1";
3642
private final String userAgentString = "MessageBird/Java ApiClient/" + clientVersion;
3743
private Proxy proxy = null;
@@ -44,8 +50,13 @@ public MessageBirdServiceImpl(final String accessKey, final String serviceUrl) {
4450
throw new IllegalArgumentException(SERVICE_URL_MUST_BE_SPECIFIED);
4551
}
4652
this.accessKey = accessKey;
53+
this.serviceUrl = serviceUrl;
4754
}
4855

56+
/**
57+
* Initiate service with default serviceUrl.
58+
* @param accessKey
59+
*/
4960
public MessageBirdServiceImpl(final String accessKey) {
5061
this(accessKey, "https://rest.messagebird.com");
5162
}

0 commit comments

Comments
 (0)