Skip to content

serviceUrl defined in Constructor of MessageBirdService not being used #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HaraldWalker opened this issue Jun 10, 2016 · 2 comments
Closed

Comments

@HaraldWalker
Copy link
Contributor

HaraldWalker commented Jun 10, 2016

Constructor of MessageBirdService allows to set the serviceUrl but the value is never being set and used. It will always use the hardcoded "https://rest.messagebird.com" as service url.

    public MessageBirdServiceImpl(final String accessKey, final String serviceUrl) {
        if (accessKey == null) {
            throw new IllegalArgumentException(ACCESS_KEY_MUST_BE_SPECIFIED);
        }
        if (serviceUrl == null || serviceUrl.length() == 0) {
            throw new IllegalArgumentException(SERVICE_URL_MUST_BE_SPECIFIED);
        }
        this.accessKey = accessKey;
    }

Not a big issue, although it allowed us to test the integration without actually using the MessageBird API.

HaraldWalker pushed a commit to Tripolis-Dialogue/java-rest-api that referenced this issue Jun 10, 2016
@Ruudieboy
Copy link

Ruudieboy commented Jun 21, 2016

Would be great if this can be merged and released to maven. We need this functionality.

@samwierema
Copy link
Contributor

Merged and published as version 1.3.0 on Maven.

Thanks @HaraldWalker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants