Allow disabling the pthread support check #6
Conversation
In cases where this code is utlized only for the libriers in it (e.g. vTPM emulation in Coconut SVSM), we do not need to compile the simulator. So it would be convenient to have the ability to disable pthread checking, which in that case is not necassary since it is used only by the simulator. Also in Coconut SVSM we don't have pthread support, so it's also a requirement and for now we have our own fork to disable this check. By default pthread checking remains enabled, so there is no change. `--disable-pthread` is added to the configure to support this new use case. Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
requested review from
chrisfenner,
bradlitterell and
amycnelson
as code owners
|
@chrisfenner @bradlitterell @amycnelson any feedback on this? We have a workaround for now, although not very nice in COCONUT SVSM: https://github.com/coconut-svsm/svsm/blob/5efb4d21b6ce03b7d06dea59b69e814f8f0a13b3/libtcgtpm/Makefile#L170 |
Sorry this PR stayed dormant. It seems fine to me, so happy to approve and merge. However, I want to share a PSA that hopefully will not be terrible news: The build system is likely to change to cmake in the next published version of this code. |
Great, thanks!
Thanks for sharing. I think it's not that bad as news :-) We will need to change something, but I think we will find a way to adapt. |
In cases where this code is utilized only for the libraries in it (e.g. vTPM emulation in Coconut SVSM), we do not need to compile the simulator.
So it would be convenient to have the ability to disable pthread checking, which in that case is not necassary since it is used only by the simulator. Also in Coconut SVSM we don't have pthread support, so it's also a requirement and for now we have our own fork to disable this check.
By default pthread checking remains enabled, so there is no change.
--disable-pthreadis added to the configure to support this new use case.