Skip to content

Display warning message if no known progress logging frontend is loaded #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

devmotion
Copy link
Member

This PR is a take on #18 (comment). I'm not sure yet how reliable this approach detects if one of the known and recommend progress logging frontends is set up, or not.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #20 into master will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   92.42%   93.24%   +0.81%     
==========================================
  Files           1        1              
  Lines          66       74       +8     
==========================================
+ Hits           61       69       +8     
  Misses          5        5              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c867a65...18586b5. Read the comment docs.

@devmotion
Copy link
Member Author

Not completely sure how to test this though, maybe one has to use SafeTestsets or manually create some modules?

@cpfiffer
Copy link
Member

cpfiffer commented Mar 4, 2020

Not completely sure how to test this though, maybe one has to use SafeTestsets or manually create some modules?

Maybe

@safetestset "Warning test" begin 
    @test_logs (:warn, warning_message) using AbstractMCMC 
end

Although I'm not sure if this will scope correctly.

@devmotion devmotion closed this Mar 6, 2020
@devmotion devmotion deleted the warning branch June 30, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants