Define model generator exactly as specified by the user #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #106 by defining a model generator with exactly the function signature that the user specified (i.e., all positional arguments and keyword arguments are preserved).
E.g.,
defines the model generator
test1(x, y = 4.0)
, whereasdefines the model generator
test2(x; y = 4.0)
. Thus in the first case one can generate a model withtest1(3.0)
andtest1(3.0, 10.0)
but nottest1(3.0, y = 10.0)
, whereas in the second case one can define a model withtest2(3.0)
andtest2(3.0; y = 10.0)
but nottest2(3.0, 10.0)
.