Skip to content

Remove the prob and logprob macros #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2024
Merged

Remove the prob and logprob macros #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f73eb3f
remove files
sunxd3 May 10, 2024
5b9f471
add alternative prob macro impl back to warn user
sunxd3 May 13, 2024
ce7026c
export again
sunxd3 May 13, 2024
a8bb505
Apply suggestions from code review
sunxd3 May 13, 2024
41f5d47
Merge branch 'master' into sunxd/remove_prob_macro
sunxd3 May 13, 2024
0f206f9
remove the macros
sunxd3 May 15, 2024
e90b4de
Update src/DynamicPPL.jl
sunxd3 May 15, 2024
deafe64
Update src/DynamicPPL.jl
yebai May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/DynamicPPL.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ export AbstractVarInfo,
# Pseudo distributions
NamedDist,
NoDist,
# Prob macros
@prob_str,
@logprob_str,
# Convenience functions
logprior,
logjoint,
Expand Down Expand Up @@ -172,7 +169,6 @@ include("varinfo.jl")
include("simple_varinfo.jl")
include("context_implementations.jl")
include("compiler.jl")
include("prob_macro.jl")
include("loglikelihoods.jl")
include("submodel_macro.jl")
include("test_utils.jl")
Expand Down
244 changes: 0 additions & 244 deletions src/prob_macro.jl
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions test/prob_macro.jl
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ include("test_util.jl")
include("simple_varinfo.jl")
include("model.jl")
include("sampler.jl")
include("prob_macro.jl")
include("independence.jl")
include("distribution_wrappers.jl")
include("contexts.jl")
Expand Down
Loading