Skip to content

Add AbstractRNG types to fix method ambiguities in Turing #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Add AbstractRNG types to fix method ambiguities in Turing #636

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d76453
Add AbstractRNG types to fix method ambiguities in Turing
penelopeysm Aug 5, 2024
fbe0d30
Format code
penelopeysm Aug 6, 2024
5bfc246
Add one more annotation
penelopeysm Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/context_implementations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,17 @@ function tilde_assume(::IsParent, context::AbstractContext, args...)
return tilde_assume(childcontext(context), args...)
end

function tilde_assume(rng, context::AbstractContext, args...)
function tilde_assume(rng::Random.AbstractRNG, context::AbstractContext, args...)
return tilde_assume(NodeTrait(tilde_assume, context), rng, context, args...)
end
function tilde_assume(::IsLeaf, rng, context::AbstractContext, sampler, right, vn, vi)
function tilde_assume(
::IsLeaf, rng::Random.AbstractRNG, context::AbstractContext, sampler, right, vn, vi
)
return assume(rng, sampler, right, vn, vi)
end
function tilde_assume(::IsParent, rng, context::AbstractContext, args...)
function tilde_assume(
::IsParent, rng::Random.AbstractRNG, context::AbstractContext, args...
)
return tilde_assume(rng, childcontext(context), args...)
end

Expand Down Expand Up @@ -121,7 +125,9 @@ end
function tilde_assume(context::PrefixContext, right, vn, vi)
return tilde_assume(context.context, right, prefix(context, vn), vi)
end
function tilde_assume(rng, context::PrefixContext, sampler, right, vn, vi)
function tilde_assume(
rng::Random.AbstractRNG, context::PrefixContext, sampler, right, vn, vi
)
return tilde_assume(rng, context.context, sampler, right, prefix(context, vn), vi)
end

Expand Down Expand Up @@ -291,7 +297,7 @@ end
function dot_tilde_assume(context::AbstractContext, args...)
return dot_tilde_assume(NodeTrait(dot_tilde_assume, context), context, args...)
end
function dot_tilde_assume(rng, context::AbstractContext, args...)
function dot_tilde_assume(rng::Random.AbstractRNG, context::AbstractContext, args...)
return dot_tilde_assume(NodeTrait(dot_tilde_assume, context), rng, context, args...)
end

Expand All @@ -309,7 +315,9 @@ function dot_tilde_assume(::IsParent, rng, context::AbstractContext, args...)
return dot_tilde_assume(rng, childcontext(context), args...)
end

function dot_tilde_assume(rng, ::DefaultContext, sampler, right, left, vns, vi)
function dot_tilde_assume(
rng::Random.AbstractRNG, ::DefaultContext, sampler, right, left, vns, vi
)
return dot_assume(rng, sampler, right, vns, left, vi)
end

Expand Down