Skip to content

Remove state-saving by default #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Remove state-saving by default #1105

merged 3 commits into from
Feb 18, 2020

Conversation

cpfiffer
Copy link
Member

Hotfix for #1091 and reports here. This PR makes it so that state is not automatically saved in a Chains object when sampling is completed -- people who want to resume the chain will have to explicitly plan ahead of time to resume sampling:

chain = sample(model, spl, N; save_state = true)

@mohamed82008
Copy link
Member

Please change prob"x = 1.0, y = 1.0 | chain = chain" to prob"x = 1.0, y = 1.0 | chain = chain, model = gdemo" in the docs, the guide.md file.

@mohamed82008
Copy link
Member

Or add both saying a word about the save_state kwarg.

@yebai
Copy link
Member

yebai commented Feb 18, 2020

@cpfiffer can you take a look at Mohamed's comment, and see whether we can fix them before merging?

@yebai
Copy link
Member

yebai commented Feb 18, 2020

Hi @yebai, I just got a benchmark command from you,
But I can't determine on which branches to run,
Please specify the branches in your command.

@KDr2 Maybe reduce unnecessary replies (e.g. only reply to comments containing @BayesBot benchmark() from the Benchmark bot?

@TuringLang TuringLang deleted a comment from BayesBot Feb 18, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 18, 2020
@cpfiffer
Copy link
Member Author

This should be good to merge once the tests pass.

@yebai yebai merged commit 9430043 into master Feb 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the cpfiffer-patch-1 branch February 18, 2020 15:27
@KDr2
Copy link
Member

KDr2 commented Feb 19, 2020

Hi @yebai, I just got a benchmark command from you,
But I can't determine on which branches to run,
Please specify the branches in your command.

@KDr2 Maybe reduce unnecessary replies (e.g. only reply to comments containing @BayesBot benchmark() from the Benchmark bot?

OK :D

@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
@TuringLang TuringLang deleted a comment from BayesBot Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants