Skip to content

CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 27, 2025

NOTE (@penelopeysm): Blocked upstream by SciML/OptimizationBase.jl#140

This pull request changes the compat entry for the ForwardDiff package from 0.10.3 to 0.10.3, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@penelopeysm penelopeysm force-pushed the compathelper/new_version/2025-03-27-00-34-51-122-04125707703 branch from b9f3232 to 8016981 Compare March 27, 2025 00:34
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.86%. Comparing base (c2605d5) to head (d9686b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2522   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files          24       24           
  Lines        1429     1429           
=======================================
  Hits         1227     1227           
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 27, 2025

Pull Request Test Coverage Report for Build 15440651954

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.924%

Totals Coverage Status
Change from base Build 15440013374: 0.0%
Covered Lines: 1227
Relevant Lines: 1428

💛 - Coveralls

@penelopeysm penelopeysm marked this pull request as draft June 3, 2025 10:13
@penelopeysm
Copy link
Member

Blocked by OptimizationBase

@yebai yebai marked this pull request as ready for review June 4, 2025 10:13
@yebai yebai enabled auto-merge June 4, 2025 10:13
Copy link
Contributor Author

github-actions bot commented Jun 4, 2025

Turing.jl documentation for PR #2522 is available at:
https://TuringLang.github.io/Turing.jl/previews/PR2522/

@yebai yebai added this pull request to the merge queue Jun 4, 2025
@penelopeysm
Copy link
Member

@yebai I'm just going to add a changelog entry if that's ok

@penelopeysm penelopeysm removed this pull request from the merge queue due to a manual request Jun 4, 2025
@penelopeysm penelopeysm enabled auto-merge June 4, 2025 11:05
@penelopeysm penelopeysm added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 6b0aae3 Jun 4, 2025
33 checks passed
@penelopeysm penelopeysm deleted the compathelper/new_version/2025-03-27-00-34-51-122-04125707703 branch June 4, 2025 13:02
@penelopeysm
Copy link
Member

just realised -- CI actually ran with ForwardDiff 0.10..

@penelopeysm
Copy link
Member

penelopeysm commented Jun 4, 2025

FD=1 is still blocked by Optimization.jl, see #2581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants