WI #2306 Protect against NullReferenceException when reading NameLiteral property #2801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efr15
requested changes
Aug 19, 2025
TypeCobol/Compiler/Parser/CodeElementBuilder/CobolExpressionsBuilder.cs
Outdated
Show resolved
Hide resolved
efr15
approved these changes
Aug 21, 2025
fm-117
deleted the
2306-nullpointerexception-in-diagnosticutilsadderrornode-node-string-message-symbolreference-symbol-messagecode-code
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2306
The
NullReferenceExceptionregularly observed in theAddErrormethod when checkingREDEFINESmay be caused by:NameLiteralbeingnullTokenof theNameLiteralbeingnull.This PR aims at fixing unsafe uses of
SymbolInformation.NameLiteral.