Skip to content

Restore functionality for --out #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basarat opened this issue Apr 9, 2015 · 9 comments
Closed

Restore functionality for --out #244

basarat opened this issue Apr 9, 2015 · 9 comments
Assignees

Comments

@basarat
Copy link
Member

basarat commented Apr 9, 2015

Its okay to show that error but don't have it block functionality

refs #206

User should be able to get intellisence + error checks

@basarat basarat self-assigned this Apr 9, 2015
@basarat basarat removed their assignment Apr 10, 2015
@basarat
Copy link
Member Author

basarat commented Apr 10, 2015

This needs a bigger rewrite in the form of warning vs. error and I'm not motivated enough by this feature. Opening it up for a hero.

@nycdotnet
Copy link
Contributor

Bas - I'm curious: In theory, with a TypeScript AST, would it be possible to programmatically figure out an appropriate concatenation order? I know it might not be perfect due to side-effects, but I suspect that it would be possible to at least avoid things like use-before-declare. Now that I'm thinking about it - I think there was a GitHub issue in the TS repo about that particular thing.

@erikvullings
Copy link

@nycdotnet I second that.
Also, instead of writing the files in tsconfig.json in alphabetical order, you could instead write them in the AST concatenation order. In that case, even if someone doesn't use the --out compiler option, a gulp/grunt script could use this file order to create a single output file.

@basarat
Copy link
Member Author

basarat commented Apr 11, 2015

In theory, with a TypeScript AST, would it be possible to programmatically figure out an appropriate concatenation order

Not in the absence of something like main (like C# / JAVA / C)

@erikvullings
Copy link

Why not specify the main class explicitly in tsconfig?

I've been using the gulp-order plugin recently. What it does is it takes a stream of input files, like the ones tsconfig generates based on the mini match, and for a subset of them, it specifies the order explicitly. So I only need to specify my base classes, and then everything can be concatenated just fine.

Couldn't you also use such an approach for generating out files?

@basarat
Copy link
Member Author

basarat commented Apr 19, 2015

Couldn't you also use such an approach for generating out files?

Supporting stuff like NPM modules is just easier with external modules. Note: NPM all things.

@martinmcwhorter
Copy link

I think @erikvullings may be onto something. We should be able to explicitly define a list of base files, or a main.ts, or a references.ts, as a starting point for --out compilation. @basarat is right, that all new projects should use modules -- but it would be nice to easily use atom-typescript on older projects that use /// with -out.

@basarat basarat self-assigned this Apr 22, 2015
@basarat
Copy link
Member Author

basarat commented Apr 22, 2015

The TypeScript compiler uses out. This means I can't look at the compiler source using atom typescript. Fixing this ASAP 🌹

@basarat
Copy link
Member Author

basarat commented Apr 22, 2015

3.0.5

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
angelestelar5z added a commit to angelestelar5z/atom-typescript that referenced this issue Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants