Skip to content

Find a way to bring in TypeScript "source" #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basarat opened this issue Apr 24, 2015 · 3 comments · Fixed by #301
Closed

Find a way to bring in TypeScript "source" #300

basarat opened this issue Apr 24, 2015 · 3 comments · Fixed by #301
Assignees

Comments

@basarat
Copy link
Member

basarat commented Apr 24, 2015

Instead of using it from package.json

Motivations:

  • I don't like getting locked out: Language Service API review microsoft/TypeScript#2899 Same reason why I'm using the full language service instead of TSServer
  • I would (and perhaps you whoever is reading) would like to hack stuff in the compiler and get an immediate feedback in the UI. Currently F12 takes me to a .d.ts that takes a lot of context away from me and I need to open another window and look at the source elsewhere.
@csnover
Copy link
Member

csnover commented Apr 24, 2015

This change now makes it impossible for me (or anyone) to easily load in a custom compiler by changing package.json and makes #236 probably impossible to implement.

@basarat
Copy link
Member Author

basarat commented Apr 25, 2015

to easily load in a custom compiler by changing package.json

Yes. But they can equivalently just copy their compiler and services folder. Just a different form of custom compiler loading.

makes #236 probably impossible to implement.

It does seem like it in first look but its actually quite easy. We just need to run their typescriptServices.js a vm context can replace our ts with their ts.

@basarat
Copy link
Member Author

basarat commented Apr 25, 2015

@csnover #236 done ;)

image

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants