Skip to content

add systemjs import syntax support to quick fix #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

add systemjs import syntax support to quick fix #787

wants to merge 4 commits into from

Conversation

jschwarty
Copy link
Contributor

Couple of thoughts on possible changes to this PR:

  • I used the project file compiler options to identify if that is set to use "system" in order to make the decision on the syntax for the import statement. Not sure if this is ideal or not...
  • I hard coded double quotes similar to the current statement, but could this be changed so the single/double quote setting from atom would be used here?

@jschwarty
Copy link
Contributor Author

I am thinking that the tsconfig.json compiler module setting should not be the deciding factor because in Angular2 the compiler options need to be module "commonJs", so maybe a package setting that allows a user to configure the import syntax?

@basarat
Copy link
Member

basarat commented Dec 18, 2015

@jschwarty thanks Justin! 🌹

I used the project file compiler options to identify if that is set to use "system" in order to make the decision on the syntax for the import statement. Not sure if this is ideal or not.

Not. Please create a new quickfix entry instead of replacing the current one. Let the user decide. Copy paste into a new file is fine 🌹

but could this be changed so the single/double quote setting from atom would be used here

Not easily as the code is running in the backend worker that has limited atom API access so might not work or break in the future. I wouldn't do it 🌹

@jschwarty
Copy link
Contributor Author

Ok, I will be afk for the weekend so I will make these changes at the start of next week and update the PR. Thanks!

@nycdotnet
Copy link
Contributor

Thanks Schwarty!

@jschwarty jschwarty closed this Dec 22, 2015
@jschwarty
Copy link
Contributor Author

Created a new PR (#791) with the suggested approach...

@ambition-consulting
Copy link

I got a missing dependency "Cannot find name ", but get no quick fix suggestion. I am on version 7.16.1. Any advice?

Thanks for your work - this feature is much needed.

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants