-
-
Notifications
You must be signed in to change notification settings - Fork 541
Closed
Description
@ejose19 Can I get a review of our top-level-await tests from you, since you wrote the initial implementation?
In the original PR for top-level await:
https://github.com/TypeStrong/ts-node/pull/1383/files
I see a couple things I'm unclear on:
When running upstream tests, we do not await
, so I think failures will be ignored:
https://github.com/TypeStrong/ts-node/pull/1383/files#diff-1d9efcccb250238d73480e5c49afae61494dd3103e9a16c38d36979f27c6ff90R2165
When calling runAndWait
we also do not await
. Why is that?
In nodejs's tests, there is await
Metadata
Metadata
Assignees
Labels
No labels