Skip to content

@types in dependencies causing build failures #350

Closed
@crazytoucan

Description

@crazytoucan

Unfortunately, we just hit the dependencies vs devDependencies issue as discussed in #310 (review). Specifically, our project:

  • Uses a different version of Lodash / its own @types/lodash.
  • Has a dev dependency on typedoc, which installs a separate version of @types/lodash

Both @types/lodash installations are being picked up by the typescript compiler, causing duplicate definition warnings. Per discussion in that thread, can we move those types back out to devDependencies to prevent the unnecessary downstream installation?

If any of the @types/ modules are actually needed by the generated typedoc.d.ts (seems like @types/handlebars might fall into this category?), I propose we inline those typings (re-expose them manually) so that we don't cause any build inconsistencies for other folks that might be using a different version of handlebars.

Will you all accept a PR for this? Any concerns about the approach?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions