-
-
Notifications
You must be signed in to change notification settings - Fork 745
Closed
Labels
wontfixDeclining to implementDeclining to implement
Description
Suddenly all my builds started to fail https://github.com/Hotell/typescript-lib-starter/pulls
The culprit here is typedoc becuase it has specific version of typescript as direct project dependencies
which overrides local node_modules/.bin/tsc
symlink to use this TS instead of TS that is used by the project.
This is a big deal.
How to fix this:
- move typescript to peerDependencies ( best solution ) ( this would be a breaking change for your library from perspective of semver )
- change typescript version in your
depencies
to^2.3.4
I can submit PR if you're willing to go through it and merge it eventually after LGTM :)
cheers
vire, datanotion, dyst5422 and sabberwormdemurgos
Metadata
Metadata
Assignees
Labels
wontfixDeclining to implementDeclining to implement