Skip to content

Default export fix #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2015
Merged

Conversation

aciccarello
Copy link
Collaborator

Fix for #111

image

Renamed exports are still documented as their local name which might be unexpected.
image

I wasn't sure how to add tests for this change.

sebastian-lenz added a commit that referenced this pull request Oct 25, 2015
@sebastian-lenz sebastian-lenz merged commit 1ccca03 into TypeStrong:master Oct 25, 2015
@sebastian-lenz
Copy link
Member

Okay, lets do it like this. But we should somehow mark default exports.

@aciccarello
Copy link
Collaborator Author

@sebastian-lenz I agree. Maybe add a note to the end of the title. Like "Class SingleExportedClass (default)". I'd have to mess around and see how it looks.

@sebastian-lenz
Copy link
Member

I'm planing to add an export table at the top of the documentations for external modules, seems to be the only reasonably way to show default exports and reexports.

@aciccarello
Copy link
Collaborator Author

Ah, I think that's a great idea. If love to see what you're thinking

On Mon, Oct 26, 2015, 4:58 AM Sebastian Lenz [email protected]
wrote:

I'm planing to add an export table at the top of the documentations for
external modules, seems to be the only reasonably way to show default
exports and reexports.


Reply to this email directly or view it on GitHub
#142 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants