add exported flag to declaration when default export - Fixes #393 #398
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ReflectionFlag.Export flag to a node's flag variable when the export converter is run. This fixes a scenario where `export default` is used in a separate statement from the variable creation, such as: ``` const foo = 'bar'; export default foo; ``` In the above example, the export converter cannot find the symbolmapping for the `foo` declaration because the createDeclaration code returns null when --excludeNotExported flag is set.
aciccarello
approved these changes
Feb 1, 2017
|
Looking at this a bit more after I've had some time to dig into the TypeScript and TypeDoc code a bit more, and I think this might not be the best approach. I probably shouldn't be changing a Node's flags or adding a Reflection flag to it. I'll research a better approach. |
|
Closing this PR. Will open a new one with a better solution to the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ReflectionFlag.Exportflag to a node's flag variable when the exportconverter is run and then check for that flag in
createDeclaration.This fixes a scenario described in #393 where
export defaultis used in a separatestatement from the variable creation, such as:
In the above example, the export converter cannot find the symbolmapping
for the
foodeclaration because the createDeclaration code returnsnull when --excludeNotExported flag is set.
Looking at the tests, it doesn't look like any of them run with
excludeNoExportset, and setting it makes several fail. SettingexcludeNoExportand running the export-default test does pass with this fix, though. I could try looking into that here, or perhaps as part of the proposed work in #378?