refactor var usage to const/let #429
Merged
+684
−670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all var usage in the project and tests, and replace it with const/let usage.
nicknisi
force-pushed
the
var-to-const-let
branch
from
4a22b05 to
f978ef5
Compare
|
I updated the commit and reverted the changes to the tests. I forgot that |
|
Also, it might be worth looking into converting the tests to TS in another PR. |
blakeembrey
reviewed
Feb 20, 2017
bin/typedoc
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env node | |||
|
|
|||
| var td = require('../dist/lib/cli.js'); | |||
| const td = require('../dist/lib/cli.js'); | |||
There was a problem hiding this comment.
Should we leave this one as var since it's JavaScript?
There was a problem hiding this comment.
I went ahead and put the var back here. It should be fine, as that usage of const is ok in Node 4, but just to be consistent, it seemed better to put it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all var usage in the project and tests, and replace it with const/let usage. This PR touches a lot of files but the only changes in each file are to convert
vartoconstorlet, and to move the declaration of variables based on the new scope rules when necessary. This is part of the refactor updates mentioned in #378.