Fix separator in getDefaultLibFileName #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove use of Path.join in the getDefaultLibFileName method that, on Windows, converts '/' in paths to '\'. TypeScript uses '/' internally so it has trouble locating the default lib location when this is reversed. Fixes TypeStrong#464 where lib directory cannot be found on Windows.
nicknisi
force-pushed
the
464-lib-in-root
branch
from
c55ae93 to
a65b42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove use of
Path.joinin thegetDefaultLibFileNamemethod that, on Windows, converts '/' in paths to '\'. TypeScript uses '/' internally so it has trouble locating the default lib location when this is reversed. Fixes #464 where lib directory cannot be found on Windows.In this PR, I changed the
getDefaultLibFileNamemethod in compiler-host.ts to more resemble that which would be returned fromts.getCompilerHost, which also included exposing a few more methods in ts-internal.ts.