- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 738
Update to latest Typescript version #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. One small question.
@@ -33,24 +33,6 @@ export class ComponentSource extends OptionsComponent { | |||
} | |||
} | |||
} | |||
|
|||
private removeComponent(component: AbstractComponent<any>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this method removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was breaking the build as it was defined, but never used: from #641:
src/lib/utils/options/sources/component.ts(37,13): error TS6133: 'removeComponent' is declared but its value is never read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. I probably should review this class to ensure that there is not an implementation bug here before I merge the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like removeComponent
should have been called in onComponentRemoved
. I probably should put together a separate PR and do some testing. Looks like the minimal theme triggers removing components.
typedoc/src/lib/output/themes/MinimalTheme.ts
Lines 21 to 24 in 6edcbd5
renderer.removeComponent('assets'); | |
renderer.removeComponent('javascriptIndex'); | |
renderer.removeComponent('navigation'); | |
renderer.removeComponent('toc'); |
There also looks to be some bugs in removeComponent
(i.e. slice
on this array will do nothing).
typedoc/src/lib/utils/options/sources/component.ts
Lines 40 to 42 in 6edcbd5
if (index !== -1) { | |
this.knownComponents.slice(index, 1); | |
for (let declaration of component.getOptionDeclarations()) { |
What's blocking this PR? Is there anything I could do to help move it forward? |
I believe now that #664 has been merged, this should be good to go. Unfortunately since the tests on the project right now are completely broken (no useful info if something changes) it's dangerous to merge anything. |
That's a shame. For now I'm using your fork directly for my project and it appears to be working fine. I don't have a particularly fancy use-case, though. |
There aren't any major blockers right now but I'll want to merge a couple more PRs and do a big dependency update before a release. |
Any update on this? |
Typedoc is not working for our current typescript version. TypeStrong/typedoc#654
@Gerrit0 I didn't merge this PR but I wanted to say thanks for figuring out what needed to be changed ❤️ |
Simple enough - I just fixed the build errors.