chore: upgrade to typescript 3.0.x #825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciccarello
reviewed
Aug 9, 2018
| @@ -98,7 +98,7 @@ export function isBindingPattern(node: ts.Node): node is ts.BindingPattern { | |||
|
|
|||
| // https://github.com/Microsoft/TypeScript/blob/v2.1.4/src/compiler/utilities.ts#L1729 | |||
| export function getClassExtendsHeritageClauseElement(node: ts.ClassLikeDeclaration | ts.InterfaceDeclaration) { | |||
| return tsany.getClassExtendsHeritageClauseElement.apply(this, arguments); | |||
| return tsany.getClassExtendsHeritageElement.apply(this, arguments); | |||
There was a problem hiding this comment.
This should probably be a separate PR and the function name should be updated
There was a problem hiding this comment.
+1 to rename the exported function in a separate PR.
There was a problem hiding this comment.
@aciccarello Do you think it's better to keep both old and new exported functions for backward compatibility?
There was a problem hiding this comment.
Since it is only used internally, I'd say change the calling function (I think there is only one) and get rid of any getClassExtendsHeritageClauseElement references.
There was a problem hiding this comment.
This gave me an idea for #830 which is related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR allows typedoc to be used with typescript 3.0.x. Once the PR is merged, it should be released as new minor version.