Skip to content

Conversation

TysonAndre
Copy link
Owner

This is extremely incomplete, and the bare minimum to serialize and
unserialize a single object property.

A real implementation would:

  • Require an option such as 'explicit_undefined' => true when unserializing
  • Reject arrays, standalone U;, etc.
  • Support __serialize() and __sleep()
  • Handle internal classes using undefined properties in serialize()
  • Add tests that internal classes such as DateTime handle invalid data properly.
  • Have more tests of edge cases
  • Fix issues identified by the fuzzer

**This is extremely incomplete, and the bare minimum to serialize and
unserialize a single object property.**
A real implementation would:

- Require an option such as 'explicit_undefined' => true when serializing
- Reject arrays, standalone U;, etc.
- Support __serialize() and __sleep()
- Handle internal classes using undefined properties in serialize()
- Add tests that internal classes such as DateTime handle invalid data properly.
- Have more tests of edge cases
- Fix remaining issues identified by the fuzzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant