Skip to content

fix(AnalyticalTable): fix border styles for different themes #7495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

fix(AnalyticalTable): fix border styles for different themes #7495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/main/src/components/AnalyticalTable/AnalyticalTable.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@

.tableHeaderRow {
height: var(--_ui5wcr-AnalyticalTableHeaderRowHeight);

div:first-child .th {
border-inline-start: 1px solid var(--sapList_BorderColor);
}
}

.hasNavigationIndicator {
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/components/AnalyticalTable/ColumnHeader/ColumnHeader.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.thContainer {
&:first-child > [role='columnheader'] {
& > [role='columnheader'][data-column-index='0'] {
border-inline-start: var(--_ui5wcr-AnalyticalTable-OuterCellBorder);
}

Expand Down
12 changes: 7 additions & 5 deletions packages/main/src/themes/sap_belize.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@

[data-sap-theme="sap_belize"] {
[data-sap-theme='sap_belize'] {
--_ui5wcr_ActionSheet_BoxShadow: var(--sapContent_HeaderShadow);
--_ui5wcr_Scrollbar_BorderRadius: 0;
--_ui5wcr_Splitter_BarBorderFocus: .0625rem dotted var(--sapContent_FocusColor);
--_ui5wcr_Splitter_BarBorderFocus: 0.0625rem dotted var(--sapContent_FocusColor);
--_ui5wcr_ActionSheet_TopBorderRadius: var(--sapElement_BorderCornerRadius);
--_ui5wcr_Splitter_BarBorderHighContrastFix: .0625rem dotted var(--sapContent_FocusColor);
}
--_ui5wcr_Splitter_BarBorderHighContrastFix: 0.0625rem dotted var(--sapContent_FocusColor);
--_ui5wcr-AnalyticalTable-OuterCellBorder: 1px solid transparent;
--_ui5wcr-AnalyticalTable-OuterBorderBlock: none;
--_ui5wcr-AnalyticalTable-OuterBorderInline: none;
}
3 changes: 3 additions & 0 deletions packages/main/src/themes/sap_belize_hcb.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,7 @@
--_ui5wcr_ActionSheet_BoxShadow: var(--sapContent_HeaderShadow);
--_ui5wcr_Scrollbar_BorderRadius: 0;
--_ui5wcr_ActionSheet_TopBorderRadius: var(--sapElement_BorderCornerRadius);
--_ui5wcr-AnalyticalTable-OuterCellBorder: 1px solid transparent;
--_ui5wcr-AnalyticalTable-OuterBorderBlock: none;
--_ui5wcr-AnalyticalTable-OuterBorderInline: none;
}
7 changes: 5 additions & 2 deletions packages/main/src/themes/sap_belize_hcw.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
[data-sap-theme="sap_belize_hcw"] {
[data-sap-theme='sap_belize_hcw'] {
--_ui5wcr_Scrollbar_Border: 0.0625rem solid #585858;
--_ui5wcr_ActionSheet_BoxShadow: var(--sapContent_HeaderShadow);
--_ui5wcr_Scrollbar_BorderRadius: 0;
--_ui5wcr_ActionSheet_TopBorderRadius: var(--sapElement_BorderCornerRadius);
}
--_ui5wcr-AnalyticalTable-OuterCellBorder: 1px solid transparent;
--_ui5wcr-AnalyticalTable-OuterBorderBlock: none;
--_ui5wcr-AnalyticalTable-OuterBorderInline: none;
}
Loading