Skip to content
This repository was archived by the owner on Feb 8, 2023. It is now read-only.

Fix undefined global console error #285

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Fix undefined global console error #285

merged 3 commits into from
Jul 27, 2018

Conversation

hursey013
Copy link
Contributor

Known bug associated with intl polyfill, fixed by importing precompiled version angular/angular-cli#8160

screen shot 2018-07-26 at 10 10 25 am

@hursey013 hursey013 force-pushed the bh_undefined_global branch from 0e0b48e to 90857f7 Compare July 26, 2018 14:52
@hursey013 hursey013 force-pushed the bh_undefined_global branch from 5d1ed0b to fb10c78 Compare July 26, 2018 15:31
@hursey013 hursey013 requested a review from lauraGgit July 26, 2018 15:57
@lauraGgit
Copy link
Contributor

@hursey013 is there a stack overflow reference to this?

@hursey013
Copy link
Contributor Author

hursey013 commented Jul 26, 2018

There is a fix shown later on in angular/angular-cli#8160 (comment). When we updated to angular-cli v6 recently, it removed the global shim which intl still needs. Importing it in a separate file like I did was to make sure it was hoisted to to the top of the polyfills to avoid the issue here: angular/angular-cli#8160 (comment)

@hursey013
Copy link
Contributor Author

@lauraGgit I guess it's worth asking if there is a plan on translating this into different languages in the near future, because if not we might consider also just removing intl for the time being.

@lauraGgit
Copy link
Contributor

@hursey013 maybe we want to check with the diversity guild?

Copy link
Contributor

@lauraGgit lauraGgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it may be worth keeping for now and it does remove that error.

@lauraGgit lauraGgit merged commit 0ff69e5 into dev Jul 27, 2018
@mtlaney mtlaney deleted the bh_undefined_global branch August 30, 2019 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants