Check if user is already authenticated, change sign in form message #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xTrig
requested changes
Jan 6, 2022
web/pages/signin.js
Outdated
| </Flex> | ||
| ); | ||
| export async function getServerSideProps({ req }) { | ||
| if (req.headers.cookie === null) return { props: { user: null } }; |
There was a problem hiding this comment.
I think we want req.cookies instead
web/pages/signin.js
Outdated
| > | ||
| <Heading>Sign In</Heading> | ||
| if (user) | ||
| return ( |
There was a problem hiding this comment.
Ideally we only want one return statement to render a component. We can conditionally render this using the {user && (<content>)} syntax like we used with the response.
web/pages/signin.js
Outdated
| ); | ||
| export async function getServerSideProps({ req }) { | ||
| if (req.headers.cookie === null) return { props: { user: null } }; | ||
| const user = await req.user; |
There was a problem hiding this comment.
If this exists and we have access to it, do we even need to check if a cookie exists? Also I don't think req.user would be an async function, so we wouldn't need to await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if there exists a session cookie, if yes then passes the user as a prop to our sign in functional component