Skip to content

CI Update: Drop support for Python 3.7 and 3.8; add 3.11 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2023
Merged

Conversation

erogluorhan
Copy link
Member

Closes #295

Overview

Removes Python 3.7 and 3.8 from and adds 3.11 to setup.py and ci.yml

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are covered when existing tests pass with Python 3.11]

@erogluorhan erogluorhan added the new feature New feature or request label May 12, 2023
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python_requires='>=3.7',

This should be changed to:

python_requires='>=3.9', 

@philipc2
Copy link
Member

Relevant Issue from Xarray: pydata/xarray#7353 (comment)

Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do some digging into the failures. Most likely one of our dependencies is not playing well with 3.11, so we might need to set up a separate 3.11 environment like Xarray excluding any failing packages.

https://github.com/pydata/xarray/blob/964d350a80fe21d4babf939c108986d5fd90a2cf/ci/requirements/environment-py311.yml

pydata/xarray#7469 (comment)

@philipc2
Copy link
Member

In our CI setup, we use we have pre_commit listed in the requirements, which has has different system expectations on conda-forge while Xarray and most other packages use pre-commit as shown here . From what I can tell, they are the same version and are built from the same repository. Unsure if this is causing any issues though

@philipc2
Copy link
Member

philipc2 commented May 16, 2023

It appears to be a conflict with Numba. Support for Numpy 1.24 and Python 3.11 was added in the 0.57.0 release, which is not available on the conda forge channel which currently hosts 0.56.4

@philipc2
Copy link
Member

@erogluorhan
Copy link
Member Author

In our CI setup, we use we have pre_commit listed in the requirements, which has has different system expectations on conda-forge while Xarray and most other packages use pre-commit as shown here . From what I can tell, they are the same version and are built from the same repository. Unsure if this is causing any issues though

I believe they should be the same, but if we couldn't find anything else that may be causing the failures, it'd be worth trying pre-commit.

@erogluorhan
Copy link
Member Author

It appears to be a conflict with Numba. Support for Numpy 1.24 and Python 3.11 was added in the 0.57.0 release, which is not available on the conda forge channel which currently hosts 0.56.4

Good catch!

@philipc2
Copy link
Member

@erogluorhan

conda-forge/numba-feedstock#115 was resolved earlier today and after some slight modifications to our environment.yml file, everything appears to be working as expected. I believe this should be ready for review now.

@erogluorhan erogluorhan marked this pull request as ready for review May 19, 2023 19:53
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anissa111
Copy link
Member

This should probably also be updated:
https://github.com/UXARRAY/uxarray/blob/bb3e12f5f392e5f39d512cca4cc33cec5d833ccc/docs/installation.rst?plain=1#L52C1-L54

After this and the tests go through I think it'll be good!

Update Python version in installation.rst
@erogluorhan
Copy link
Member Author

This should probably also be updated: https://github.com/UXARRAY/uxarray/blob/bb3e12f5f392e5f39d512cca4cc33cec5d833ccc/docs/installation.rst?plain=1#L52C1-L54

After this and the tests go through I think it'll be good!

Good catch! Updated now.

@erogluorhan
Copy link
Member Author

This should probably also be updated: https://github.com/UXARRAY/uxarray/blob/bb3e12f5f392e5f39d512cca4cc33cec5d833ccc/docs/installation.rst?plain=1#L52C1-L54
After this and the tests go through I think it'll be good!

Good catch! Updated now.

Since tests are passing, merging this now per the comment and one existing approval.

@erogluorhan erogluorhan merged commit 03194ce into main May 21, 2023
@erogluorhan erogluorhan deleted the ci_update branch June 9, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Python 3.8 and support 3.11
3 participants