-
Notifications
You must be signed in to change notification settings - Fork 39
CI Update: Drop support for Python 3.7 and 3.8; add 3.11 #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant Issue from Xarray: pydata/xarray#7353 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some digging into the failures. Most likely one of our dependencies is not playing well with 3.11, so we might need to set up a separate 3.11 environment like Xarray excluding any failing packages.
In our CI setup, we use we have |
It appears to be a conflict with Numba. Support for Numpy 1.24 and Python 3.11 was added in the |
I believe they should be the same, but if we couldn't find anything else that may be causing the failures, it'd be worth trying pre-commit. |
Good catch! |
conda-forge/numba-feedstock#115 was resolved earlier today and after some slight modifications to our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This should probably also be updated: After this and the tests go through I think it'll be good! |
Update Python version in installation.rst
Good catch! Updated now. |
Since tests are passing, merging this now per the comment and one existing approval. |
Closes #295
Overview
Removes Python 3.7 and 3.8 from and adds 3.11 to setup.py and ci.yml
PR Checklist
General
Testing