#284 Optimization of VC UTBot Quickstart wizard #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support CMake-generated version - `disabled` and `checked` attribute support for Unix/MS HTML render - added client/server version verification at `Handshake` call - deep refactoring `.css` files - remove `Test server` button and make the mandatory job in background - remove useless class `WizardHTMLBuilder` - fix CMake parameter editor
ladisgin
approved these changes
Jun 29, 2022
vscode-plugin/media/wizard.html
Outdated
| <b>📶 Connection</b> | ||
| <span> | ||
| <span id="connection_loader">⏳ Connecting...</span> | ||
| <span id="connection_success">✔️Successfully pinged server! </span> |
vscode-plugin/media/wizard.js
Outdated
Comment on lines
33
to
36
| // vscode.postMessage({ | ||
| // command: 'dbg_message', | ||
| // message: message | ||
| // }); |
vscode-plugin/media/wizard.js
Outdated
| * Communication with VSCode via API | ||
| */ | ||
| const vscode = acquireVsCodeApi(); | ||
| function setupLocalHost() { |
| return host === '127.0.0.1' || host === 'localhost'; | ||
| } | ||
|
|
||
| public static isRemoteScenario(): boolean { |
- fix `isRemoteScenario` for local-remote scenario (remote root != project path)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabledandcheckedattribute support for Unix/MS HTML renderHandshakecall.cssfilesTest serverbutton and make the mandatory job in backgroundWizardHTMLBuilder