Skip to content

Implement close functions for UMachine and USolver classes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023

Conversation

CaelmBleidd
Copy link
Member

We forgot to implement close functions in UMachine and USolver classes. It caused a bug when analysis never ends due to unreleased native resources in KYicesSolver in UMachine.

For now, I made UMachine responsible for closing a solver instance, but later we might change it if we want to make UComponents a shared instance between different machines.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
6543 6543
@CaelmBleidd CaelmBleidd mentioned this pull request May 25, 2023
24 tasks
@CaelmBleidd CaelmBleidd merged commit 31170a2 into main May 25, 2023
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/closeable branch May 26, 2023 09:11
DaniilStepanov pushed a commit that referenced this pull request Nov 15, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
6543 6543
petrukhinandrew added a commit to petrukhinandrew/usvm that referenced this pull request Apr 18, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* add spy support

* style fixes
petrukhinandrew added a commit to petrukhinandrew/usvm that referenced this pull request May 5, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* add spy support

* style fixes
Saloed pushed a commit that referenced this pull request Jun 2, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
petrukhinandrew added a commit to petrukhinandrew/usvm that referenced this pull request Jun 19, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* add spy support

* style fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants