Replaced access path bases with access paths in backward dataflow #282
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
What does the What about the "quality"? Comparing only the performance is not enough for such major change. Pick a metric (number of inferred types, ratio of all type, ratio of annotated type, number of inferred calls, etc) and add "old/new quality" columns. |
MForest7
force-pushed
the
mforest/ets-access-paths-in-backward
branch
from
094d735 to
3f5fdde
Compare
| doAddKnownTypes: Boolean = true, | ||
| ) : Analyzer<BackwardTypeDomainFact, AnalyzerEvent, EtsMethod, EtsStmt> { | ||
|
|
||
| override val flowFunctions = BackwardFlowFunctions(graph, dominators, savedTypes, doAddKnownTypes) |
There was a problem hiding this comment.
We probably want to keep savedTypes, or somehow justify its removal and clean up the forward flow functions accordingly.
| val typeRefinement = typeRefinements[propertyPath] | ||
| val refinedType = if (type != null && typeRefinement != null) { | ||
| typeProcessor.intersect(typeRefinement, type) | ||
| } else type ?: typeRefinement |
There was a problem hiding this comment.
Add { ... } braces to the else block.
|
|
||
| refined | ||
| } | ||
| /*.mapValues { (_, typeFacts) -> |
| logger.warn { "Empty intersection type: ${acc.toStringLimited()} & ${typeFact.toStringLimited()}" } | ||
| acc | ||
| } | ||
| } |
Replaced nested objects in backward dataflow with access paths, also get a performance increase.