NetworkSet does not have any public method `Add`.

[luismasuelli]

Describe the bug
There is no public Add method for the NetworkSet!

To Reproduce
Just write code (it will NOT compile):

1. Declare a NetworkSet variable, inside a behaviour or whatever class/file you want to declare. Ensure this new, test, code you are writing is NOT in the same assembly/directory of MLAPI, but in an external directory (e.g. a main Scripts directory in the project root, and the MLAPI in another directory, with its own assembly definition).
2. Try invoking yourVariable.Add(anInstanceOfWatever).
3. Try compiling.

Actual outcome
A compilation error: 'NetworkSet' does not contain a definition for 'Add' and no accessible extension method 'Add' accepting a first argument of type 'NetworkSet' could be found (are you missing a using directive or an assembly reference?)

Expected outcome
No compilation error.

Screenshots

Environment:

• OS: Windows 10
• Unity Version: 2020.3.12f1
• MLAPI Version: 0.1.1
• MLAPI Commit: ee59d5f (corresponds literally to tag 0.1.1).

Additional context
I notice there are two implementations of Add. One coming from ICollection and one coming from ISet. Both have almost the same code (save for a dumb return true in the case of ISet implementation, but with no return false counterpart).

My suggestion is:

1. Make them public. At least, one of them (by default they are internal).
2. In the bool ISet<T>.Add case, at least, ask the result of the m_Set.Add operation. On false, the element is already present and nothing changed: avoid triggering dirtiness / OnSetChanged.

[mattwalsh-unity]

Yeah, I ran into the same issue myself. The problem is we're extending 2 interfaces that both support Add. I'm looking at cleaning up this interface to have a simpler, single, public Add method.

In the meantime, if you look at this PR #1000 or specifically this file you can see how you can do it today albeit clunk-ily.

Here's an example:

ISet<int> iSet = m_ServerComp.TheSet;
iSet.Add(k_TestVal1);
iSet.Add(k_TestVal2);

Lastly, although this won't help this specific issue, may I invite you to switch over to the master release branch? Or if you want to play with our very latest, unreleased development area we have a develop branch

[mattwalsh-unity]

I forgot to mention, because of how C# works, we can't just make those explicit interface implementations public. They are public, really - it's just they're only invokable from something that is specifically an interface, hence the workaround I had in my last comment.

https://stackoverflow.com/questions/1253266/why-explicit-implementation-of-a-interface-can-not-be-public

[will-mearns]

Fixed with PR#1022