Wrong IsOwner/IsOwnedByServer in NetworkBehaviour on Server

[Myxcil]

Description

com.unity.netcode.gameobjects/com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs

Lines 217 to 219 in ba30286

	UpdateOwnershipTable(networkObject, NetworkManager.ServerClientId, true);
	networkObject.OwnerClientId = NetworkManager.ServerClientId;

When a client owner is removed UpdateNetworkProperties is called on the server with the previous OwnerClientId still set, which leads to wrong values in NetworkBehaviour.IsOwner, IsOwnedByServer and OwnerClientId

Not sure if a simple swap of lines 217 and 219 will introduce side effects, so I haven't created a pull request.

Reproduce Steps

Remove ownership from an object which is controlled by a client and has a NetworkBehaviour assigned.
Compare IsOwner etc. properties between NetworkObject and the behaviour on the server.

Actual Outcome

NetworkBehaviour properties aren't properly set on the server.

Expected Outcome

Correct owner is set in the NetworkBehaviours on the server after ownership is lost.

Environment

• OS: Windows
• Unity Version: 2021.1.24f1
• Netcode Version: 1.0.0

[NoelStephensUnity]

Hi @Myxcil !
Just to make sure I am understanding the underlying issue:

Server-Side: (problematic)

1. When an ownership is removed, UpdateOwnershipTable is invoked
2. The only place where I could see this would be an issue is within UpdateOwnershipTable it will invoke networkObject.InvokeBehaviourOnLostOwnership()
3. If you try to check the OwnerClientId (or any property that uses that) it will still be the previous Owner.

Client-Side (works fine)
When the ChangeOwnershipMessage is received on the clients:

1. The new OwnerClientId is applied first and then the UpdateOwnershipTable is invoked
2. For clients this should be fine.

This does indeed seem that simply swapping the order of operations would fix the server-side only issue. 👍
Once you confirm that this is in-line with the issue you are experiencing, I can get this issue into the bug pipeline and whip together your suggested fix.

[ashwinimurt]

Backlog: MTT-4259

[Myxcil]

Hi Noel, Yes it was an issue on the server only when a client lost the ownership of an object. Your summary is correct. Looking forward to the patch . Have a nice day Markus Kark Noel Stephens ***@***.***> schrieb am Do., 28. Juli 2022, 22:57:

…

Hi @Myxcil <https://github.com/Myxcil> ! Just to make sure I am understanding the underlying issue: *Server-Side:* (*problematic*) 1. When an ownership is removed, UpdateOwnershipTable is invoked 2. The only place where I could see this would be an issue is within UpdateOwnershipTable it will invoke networkObject.InvokeBehaviourOnLostOwnership() 3. If you try to check the OwnerClientId (or any property that uses that) it will still be the previous Owner. *Client-Side* (*works fine*) When the ChangeOwnershipMessage is received on the clients: 1. The new OwnerClientId is applied first and then the UpdateOwnershipTable is invoked 2. For clients this should be fine. This does indeed seem that simply swapping the order of operations would fix the server-side only issue indeed! Once you confirm that this is in-line with the issue you are experiencing, I can get this issue into the bug pipeline and whip together your suggested fix. — Reply to this email directly, view it on GitHub <#2063 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3SA6I6755F4AL4YXC6OLDVWLX4LANCNFSM53OZJDXQ> . You are receiving this because you were mentioned.Message ID: <Unity-Technologies/com.unity.netcode.gameobjects/issues/2063/1198624425@ github.com>