Animation curves generating NetworkAnimator warnings

[MiTschMR]

Description

I use an asset called Game Creator 2 by Catsoft Works which introduced animation curves in their last update 2.8.31 and integrate that into Easy UGS by MiTschMR Studios (which I am the dev of). I linked their animation component within Network Animator and instantiate their player. When moving, animations with curves generate warnings within the NetworkAnimator.

Reproduce Steps

1. Import GC2 into the project
2. Import Easy UGS into the project
3. Follow https://mitschmr-studios.io/documentation/easyugs/netcode/getstarted.html
4. Move the player and check the console

Actual Outcome

Warnings like this are thrown:

Parameter 'Hash -819361287' is controlled by a curve.
UnityEngine.Animator:SetFloat (int,single)
Unity.Netcode.Components.NetworkAnimator:ReadParameters (Unity.Netcode.FastBufferReader) (at Library/PackageCache/com.unity.netcode.gameobjects@1.2.0/Components/NetworkAnimator.cs:1039)
Unity.Netcode.Components.NetworkAnimator:UpdateParameters (Unity.Netcode.Components.NetworkAnimator/ParametersUpdateMessage) (at Library/PackageCache/com.unity.netcode.gameobjects@1.2.0/Components/NetworkAnimator.cs:1060)
Unity.Netcode.Components.NetworkAnimatorStateChangeHandler:NetworkUpdate (Unity.Netcode.NetworkUpdateStage) (at Library/PackageCache/com.unity.netcode.gameobjects@1.2.0/Components/NetworkAnimator.cs:69)
Unity.Netcode.NetworkUpdateLoop:RunNetworkUpdateStage (Unity.Netcode.NetworkUpdateStage) (at Library/PackageCache/com.unity.netcode.gameobjects@1.2.0/Runtime/Core/NetworkUpdateLoop.cs:185)
Unity.Netcode.NetworkUpdateLoop/NetworkPreUpdate/<>c:<CreateLoopSystem>b__0_0 () (at Library/PackageCache/com.unity.netcode.gameobjects@1.2.0/Runtime/Core/NetworkUpdateLoop.cs:232)

Expected Outcome

No warnings are thrown.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

• OS: Windows 11 22H2 (Build 22621.1105)
• Unity Version: 2021.3.4f1
• Netcode Version: 1.2.0

Additional Information

According to the GC2 dev, If a "bone" with a curve is called the same as a "parameter" it's then bound to the curve.
You could check for that and skip if that is the case, otherwise set it as usual.

[NoelStephensUnity]

@MiTschMR
Sorry for the delay, this required some additional internal testing to identify the issue and resolve it in a way that was compatible with both packages required to replicate the issue.

With the pending PR fix, NetworkAnimator will now include all parameters in its internal list to check for deltas and cull out any parameter currently controlled by an AnimationCurve when it checks for parameter deltas during runtime. It also removes that pesky exception that would happen when you disabled the Animator in order to assign the new one.

Side Notes & Suggestions:

• You might change the instructions to add the NetworkAnimator directly to the Mannequin child GameObject as opposed to the Player GameObject as that works just as well.
• You might include screenshots in the instructions as some were a bit confusing (especially the assignment of the NetworkDirectional player motion).
• In the UnitPlayerDirectionalNetwork, you might think about saving the last InputDirection and speed to private properties and compare the current against the previous each update to determine whether you need to send an RPC or not (otherwise you will be sending an RPC every update even if nothing has changed).

Either case, very interesting project and the fix for this issue is in the queue! 👍

[MiTschMR]

Hi Noel, thank you very much for your reply! I am looking forward to the changes made.

About the side notes and suggestions, also thank you very much for them, appreciate the insight in optimization.
About the screenshots, yeah, as the dev of something it is always easy to say "Hey, that's not working", but might be difficult for others to understand. Need to improve on that ^^.

[NoelStephensUnity]

The PR has been merged and will be in the update after the coming v1.3.0 update.