chore: expose --verbosity through standards.py
#1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
commented
Aug 25, 2021
| parser.add_argument("--fix", action="store_true") | ||
| parser.add_argument("--yamato", action="store_true") | ||
|
|
||
| parser.add_argument("--verbosity", default="minimal") |
There was a problem hiding this comment.
this is the real addition in the PR, other file changes are simply results from running ./standards.py --fix locally.
0xFA11
commented
Aug 25, 2021
| for project_file in glob_files: | ||
| print(f"check: project -> {project_file}") | ||
| any_error = 0 != os.system(f"{args.tool_path} {project_file} --fix-whitespace --fix-style error --check") or any_error | ||
| any_error = 0 != os.system(f"{args.tool_path} {project_file} --fix-whitespace --fix-style error --check --verbosity {args.verbosity}") or any_error |
There was a problem hiding this comment.
and this is how it's being used/passed.
mattwalsh-unity
approved these changes
Aug 25, 2021
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.