fix: issue #1151 - client RPCs invoked in OnNetworkSpawn being dropped #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
requested review from
0xFA11,
LukeStampfli,
NoelStephensUnity and
mattwalsh-unity
0xFA11
approved these changes
Sep 30, 2021
| continue; | ||
| } | ||
|
|
||
| Debug.Log($"Sending {typeof(TMessageType)} to {clientId}"); |
There was a problem hiding this comment.
I think this got added by mistake? As it's quite spammy I guess?
There was a problem hiding this comment.
Good call, removed.
LukeStampfli
approved these changes
Sep 30, 2021
# Conflicts: # testproject/Assets/Tests/Runtime/Support/SpawnRpcDespawn.cs
|
Closing this because when working on another issue, I realized this needs a fundamentally different approach. I'll reopen later. |
…g dropped" This reverts commit d7d7bd7. # Conflicts: # com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs # testproject/Assets/Tests/Runtime/MessageOrdering.cs # testproject/Assets/Tests/Runtime/Support/SpawnRpcDespawn.cs
…d before the object is spawned.
0xFA11
reviewed
Oct 5, 2021
0xFA11
reviewed
Oct 5, 2021
com.unity.netcode.gameobjects/Runtime/Spawning/NetworkSpawnManager.cs
Outdated
Show resolved
Hide resolved
NoelStephensUnity
approved these changes
Oct 5, 2021
jeffreyrainy
reviewed
Oct 6, 2021
| GetComponent<NetworkObject>().Spawn(); | ||
| IncrementUpdateCount(); | ||
| GetComponent<NetworkObject>().Despawn(false); | ||
| Destroy(gameObject); |
There was a problem hiding this comment.
I'm curious about this change. Is this needed for this fix or an unrelated behaviour change. It's quite likely to be a better idea to destroy, but I wonder if it is part of the fix.
jeffreyrainy
approved these changes
Oct 6, 2021
…ager.cs Co-authored-by: M. Fatih MAR <[email protected]>
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…Spawn being dropped (Unity-Technologies#1218) * fix: issue Unity-Technologies#1151 - client RPCs invoked in OnNetworkSpawn being dropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.