fix: load event completed fires early (#1379) #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix Only allow a host to include itself in the clients completed list of a SceneEventProgress (i.e. don't include dedicate-server only). * style adding adjusted comments. * test Updated SceneLoadingAndNotifications to run as a host and a server in order to test that when running as a server the SceneEventType.LoadEventCompleted and SceneEventType.UnloadEventCompleted events are triggered without the server being added to the ClientsThatCompleted list within the SceneEvent. * update changelog Updating the changelog file with this fix information.
0xFA11
approved these changes
Nov 24, 2021
andrews-unity
deleted the
backport/1.0.0-fix-LoadEventCompleted-fires-early
branch
mollstam
pushed a commit
to Keepsake-Games/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 13, 2023
…y-Technologies#1464) * fix Only allow a host to include itself in the clients completed list of a SceneEventProgress (i.e. don't include dedicate-server only). * style adding adjusted comments. * test Updated SceneLoadingAndNotifications to run as a host and a server in order to test that when running as a server the SceneEventType.LoadEventCompleted and SceneEventType.UnloadEventCompleted events are triggered without the server being added to the ClientsThatCompleted list within the SceneEvent. * update changelog Updating the changelog file with this fix information. Co-authored-by: Unity Netcode CI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1379